Discussion:
[GitHub] commons-text pull request #91: TEXT-127 Detect when a variable is unknown in...
drajakumar
2018-10-29 18:11:35 UTC
Permalink
GitHub user drajakumar opened a pull request:

https://github.com/apache/commons-text/pull/91

TEXT-127 Detect when a variable is unknown in StringSubstitutor



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/drajakumar/commons-text master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91

----
commit d3bfb518ccde125b45b9d7a874cf717321578e7f
Author: Don Jeba <***@...>
Date: 2018-10-29T18:05:19Z

TEXT-127 Detect when a variable is unknown in StringSubstitutor

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
coveralls
2018-10-29 18:36:01 UTC
Permalink
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/91


[![Coverage Status](https://coveralls.io/builds/19787137/badge)](https://coveralls.io/builds/19787137)

Coverage increased (+0.002%) to 97.876% when pulling **60bed4374a2db82bc7842d3ccd33e2158d2b80f6 on drajakumar:master** into **6c3cc5239c2143256976c9e8a05dd76b31c74baf on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
drajakumar
2018-10-31 12:30:53 UTC
Permalink
Github user drajakumar closed the pull request at:

https://github.com/apache/commons-text/pull/91


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
drajakumar
2018-10-31 12:33:36 UTC
Permalink
Github user drajakumar commented on the issue:

https://github.com/apache/commons-text/pull/91

closed the pr as @garydgregory made applied a different patch that changes the instance variable name and method name. He also provided the variable name that is not found. He added some missing Javadoc throws tags. https://github.com/apache/commons-text/commit/ed94773e2d2e4da4e993e5a50ee72624587cf76b


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Continue reading on narkive:
Search results for '[GitHub] commons-text pull request #91: TEXT-127 Detect when a variable is unknown in...' (Questions and Answers)
155
replies
I'm 19, a Christian, but gradually turning into an atheist...please help?
started 2015-04-05 07:04:59 UTC
religion & spirituality
Loading...