Discussion:
[GitHub] commons-rng pull request #10: Improvement rng 51
aherbert
2018-09-21 14:21:51 UTC
Permalink
GitHub user aherbert opened a pull request:

https://github.com/apache/commons-rng/pull/10

Improvement rng 51

RNG-51: Added a PoissonSamplerCache that exploits the fact that the state of the LargeMeanPoissonSampler is constant for all means in the range `n <= mean < n+1` where `n` is the floor of the mean.

A JMH speed test has been added to show the expected performance benefit for single-use Poisson samples.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aherbert/commons-rng improvement-RNG-51

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10

----
commit fa38dea519c49640c485299d47516f9fb3d51fde
Author: Alex Herbert <***@...>
Date: 2018-09-20T22:17:36Z

RNG-51: Added a PoissonSamplerCache for the large mean algorithm

commit db751b911b56fecff1bce1ce33320e4308158c6a
Author: Alex Herbert <***@...>
Date: 2018-09-20T23:56:19Z

RNG-51: Changed representation of LargeMeanPoissonSampler state

commit b7723280bcaeb0ce9700d47cfc96b925d8a607cb
Author: Alex Herbert <***@...>
Date: 2018-09-21T00:03:19Z

RNG-51: The LargeMeanPoissonSamplerState should be final

commit 120d275ed34b4d5b9a0729e788382ffa39d050ce
Author: aherbert <***@...>
Date: 2018-09-21T13:52:16Z

RNG-51: Added JMH performance test

commit 21927cbc3005e5a7f3a45c527597a5733d735b4d
Author: aherbert <***@...>
Date: 2018-09-21T13:55:37Z

Merge branch 'master' of git://github.com/apache/commons-rng into improvement-RNG-51

commit ef5470249ca404a28b7106d1a16ae768ad224cda
Author: aherbert <***@...>
Date: 2018-09-21T14:11:45Z

RNG-51: Updated for 1.2-SNAPSHOT

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
coveralls
2018-09-21 14:36:29 UTC
Permalink
Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/10


[![Coverage Status](https://coveralls.io/builds/19124726/badge)](https://coveralls.io/builds/19124726)

Coverage increased (+0.4%) to 97.501% when pulling **ef5470249ca404a28b7106d1a16ae768ad224cda on aherbert:improvement-RNG-51** into **f5599152a715a987f36d7606ba3a967b7d297501 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
asfgit
2018-09-22 17:50:50 UTC
Permalink
Github user asfgit closed the pull request at:

https://github.com/apache/commons-rng/pull/10


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Loading...