drajakumar
2018-11-07 09:53:57 UTC
GitHub user drajakumar opened a pull request:
https://github.com/apache/commons-text/pull/92
TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable
1 considered the end index as exclusive because its exclusive as per the definition done in Appendable.
2 considered start index not to be same as the end index because start index is inclusive, end index is not.
3 there is an overloaded append function in TextStringBuilder which takes String, int, int as parameters. The last parameter here is length. I didn't touch this because, its NOT an overridden function from Appendable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drajakumar/commons-text master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit d3bfb518ccde125b45b9d7a874cf717321578e7f
Author: Don Jeba <***@...>
Date: 2018-10-29T18:05:19Z
TEXT-127 Detect when a variable is unknown in StringSubstitutor
commit dde0a395438bf8c7626076c56912a4405f856628
Author: Don Jeba <***@...>
Date: 2018-10-29T18:21:04Z
fixing build failure
commit 60bed4374a2db82bc7842d3ccd33e2158d2b80f6
Author: Don Jeba <***@...>
Date: 2018-10-29T18:29:19Z
removing trailing space at L131
commit 2ac7b5029cea1234accca7ec5f48cf17bed364ac
Author: Don Jeba <***@...>
Date: 2018-11-07T09:33:50Z
TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable
commit a7d1a89e9aafa2f296758583e661c13f2ab58c20
Author: Don Jeba <***@...>
Date: 2018-11-07T09:42:24Z
fixing merge conflict
commit a8d94daaa59eef6709b70e66a46319c3c75cd718
Author: Don Jeba <***@...>
Date: 2018-11-07T09:45:30Z
removing empty lines from StringSubstitutorTest.java
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
https://github.com/apache/commons-text/pull/92
TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable
1 considered the end index as exclusive because its exclusive as per the definition done in Appendable.
2 considered start index not to be same as the end index because start index is inclusive, end index is not.
3 there is an overloaded append function in TextStringBuilder which takes String, int, int as parameters. The last parameter here is length. I didn't touch this because, its NOT an overridden function from Appendable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drajakumar/commons-text master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit d3bfb518ccde125b45b9d7a874cf717321578e7f
Author: Don Jeba <***@...>
Date: 2018-10-29T18:05:19Z
TEXT-127 Detect when a variable is unknown in StringSubstitutor
commit dde0a395438bf8c7626076c56912a4405f856628
Author: Don Jeba <***@...>
Date: 2018-10-29T18:21:04Z
fixing build failure
commit 60bed4374a2db82bc7842d3ccd33e2158d2b80f6
Author: Don Jeba <***@...>
Date: 2018-10-29T18:29:19Z
removing trailing space at L131
commit 2ac7b5029cea1234accca7ec5f48cf17bed364ac
Author: Don Jeba <***@...>
Date: 2018-11-07T09:33:50Z
TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable
commit a7d1a89e9aafa2f296758583e661c13f2ab58c20
Author: Don Jeba <***@...>
Date: 2018-11-07T09:42:24Z
fixing merge conflict
commit a8d94daaa59eef6709b70e66a46319c3c75cd718
Author: Don Jeba <***@...>
Date: 2018-11-07T09:45:30Z
removing empty lines from StringSubstitutorTest.java
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org