Discussion:
[GitHub] commons-rng pull request #14: fix: removed 1.8 annotation to ensure 1.7 comp...
aherbert
2018-11-19 15:15:52 UTC
Permalink
GitHub user aherbert opened a pull request:

https://github.com/apache/commons-rng/pull/14

fix: removed 1.8 annotation to ensure 1.7 compliance

Noticed this JDK 1.8 annotation when compiling on a machine with Open JDK 1.7 (it broke).

The pom.xml for commons-rng-examples uses 1.7 as the compliance level so this should be removed. The interface is not used with Lambda expressions anyway, i.e. the annotation should not be there.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aherbert/commons-rng fix-jmh-java-version-1.7-compliance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14

----
commit 6dca4630fb4df34eb5e106dfbbe66bff271526ee
Author: aherbert <***@...>
Date: 2018-11-19T15:11:59Z

fix: removed 1.8 annotation to ensure 1.7 compliance

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
coveralls
2018-11-19 15:24:41 UTC
Permalink
Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/14


[![Coverage Status](https://coveralls.io/builds/20181767/badge)](https://coveralls.io/builds/20181767)

Coverage remained the same at 97.544% when pulling **6dca4630fb4df34eb5e106dfbbe66bff271526ee on aherbert:fix-jmh-java-version-1.7-compliance** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
coveralls
2018-11-19 15:24:41 UTC
Permalink
Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/14


[![Coverage Status](https://coveralls.io/builds/20181767/badge)](https://coveralls.io/builds/20181767)

Coverage remained the same at 97.544% when pulling **6dca4630fb4df34eb5e106dfbbe66bff271526ee on aherbert:fix-jmh-java-version-1.7-compliance** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
asfgit
2018-11-20 21:19:52 UTC
Permalink
Github user asfgit closed the pull request at:

https://github.com/apache/commons-rng/pull/14


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Loading...