Discussion:
[GitHub] commons-rng pull request #12: RNG-57: Cache values for provision of nextBool...
aherbert
2018-11-16 17:40:21 UTC
Permalink
GitHub user aherbert opened a pull request:

https://github.com/apache/commons-rng/pull/12

RNG-57: Cache values for provision of nextBoolean and nextInt

This PR contains the suggested changes to implement a cache to speed up the `nextInt` and `nextBoolean` methods in the core provider implementations.

These changes improve performance but the effect on the `nextInt` method of `LongProvider` is unknown. A repeat of the DieHarder and TestU01 test suites is currently in progress.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aherbert/commons-rng improvement-RNG-57

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12

----
commit 91a5eec2d8a3318cf8fc8e6d222ac3edf3a0d969
Author: aherbert <***@...>
Date: 2018-11-16T13:10:51Z

RNG-57: Cache values for provision of nextBoolean and nextInt

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
coveralls
2018-11-16 17:47:08 UTC
Permalink
Github user coveralls commented on the issue:

https://github.com/apache/commons-rng/pull/12


[![Coverage Status](https://coveralls.io/builds/20148825/badge)](https://coveralls.io/builds/20148825)

Coverage decreased (-0.2%) to 97.358% when pulling **91a5eec2d8a3318cf8fc8e6d222ac3edf3a0d969 on aherbert:improvement-RNG-57** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
asfgit
2018-11-20 21:19:54 UTC
Permalink
Github user asfgit closed the pull request at:

https://github.com/apache/commons-rng/pull/12


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Loading...