[GitHub] commons-rng pull request #11: RNG-57: Cache values for nextBoolean() and nex...

[aherbert]

GitHub user aherbert opened a pull request:

https://github.com/apache/commons-rng/pull/11

RNG-57: Cache values for nextBoolean() and nextInt()

AbstractIntProvider has been updated to cache a value for nextBoolean().

AbstractLongProvider has been updated to cache a value for nextBoolean()
and nextInt().

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aherbert/commons-rng improvement-RNG-57

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-rng/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11

----
commit 58afa68ebef161fa938c06ceed6bc324e8367e4a
Author: aherbert <***@...>
Date: 2018-10-03T10:54:37Z

RNG-57: Cache values for nextBoolean() and nextInt()

AbstractIntProvider has been updated to cache a value for nextBoolean().

AbstractLongProvider has been updated to cache a value for nextBoolean()
and nextInt().

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[aherbert]

Github user aherbert commented on the issue:

https://github.com/apache/commons-rng/pull/11

This failed. This is partly due to 'Too many failures ...' in the testing of the different providers. This is for code I have not touched as the tests are for IntProvider.nextInt() and LongProvider.nextLong(). I assume they would pass on repeat since they are random. Note that different provider tests failed for JDK 7, 8 and 9 due to randomness.

There are also a failures for ProvidersCommonParametricTest.testStateSettable().

This has not been fixed and was intended to be part of a different PR (see [RNG-57](https://issues.apache.org/jira/browse/RNG-57?focusedCommentId=16635531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16635531)).

However it may be best implemented together to make the PR atomic.

This will take a bit of time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[aherbert]

Github user aherbert commented on the issue:

https://github.com/apache/commons-rng/pull/11

[RNG-58](https://issues.apache.org/jira/browse/RNG-58) addresses the setting of the state, allowing state to be stored at any level of the hierarchy below `BaseProvider`.

This PR has been updated to use that functionality.

The build now fails due to the randomness of testing.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[aherbert]

Github user aherbert closed the pull request at:

https://github.com/apache/commons-rng/pull/11


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[aherbert]

Github user aherbert commented on the issue:

https://github.com/apache/commons-rng/pull/11

This branch has too many commits. I am closing the PR and will create a new one from master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org