[GitHub] commons-collections pull request #53: updating containsKey method in Passive...

[thePatmanMI]

GitHub user thePatmanMI opened a pull request:

https://github.com/apache/commons-collections/pull/53

updating containsKey method in PassiveExpiringMap

correcting the containsKey method to remove all expired entries to match the class and method javadoc statements

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thePatmanMI/commons-collections patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53

----
commit 8a004e019a2fe269431b12ec82824fb372e5380f
Author: thePatmanMI <***@...>
Date: 2018-09-19T13:57:06Z

updating containsKey method in PassiveExpiringMap

correcting the containsKey method to remove all expired entries to match the class and method javadoc statements

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[thePatmanMI]

Github user thePatmanMI commented on the issue:

https://github.com/apache/commons-collections/pull/53

I can do that. Do you have a preference on whether I should use reflection to access the underlying map(s) (to determine size) or if I should change the underlying map(s) to be package scope instead?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[thePatmanMI]

Github user thePatmanMI commented on the issue:

https://github.com/apache/commons-collections/pull/53

are there additional problems with this change, or can it be merged in?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org