Discussion:
[GitHub] commons-collections pull request #54: Replace Clirr with japicmp, since clir...
britter
2018-09-20 07:27:31 UTC
Permalink
GitHub user britter opened a pull request:

https://github.com/apache/commons-collections/pull/54

Replace Clirr with japicmp, since clirr does not handle Java 8 defaul



t methods

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/britter/commons-collections fix-broken-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54

----
commit 9fdff0135e295d13d2ceca01bddd5dccb530722a
Author: Benedikt Ritter <***@...>
Date: 2018-09-20T07:27:01Z

Replace Clirr with japicmp, since clirr does not handle Java 8 default methods

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
britter
2018-09-20 07:32:40 UTC
Permalink
Github user britter commented on the issue:

https://github.com/apache/commons-collections/pull/54

The build produces:

```
[INFO] --- japicmp-maven-plugin:0.12.0:cmp (default-cli) @ commons-collections4 ---
[INFO] Skipping execution because parameter 'skip' was set to true.
```

And I don't understand why. When calling `mvn site`, the japicmp report is created. But the check goal is always skipped...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Loading...