[ALL] Spaces in paths - change Jenkins jobs to use spaces?

[sebb]

IO-589 was accidentally found by trying to test in a path which
happened to contain a space.
This revealed a bug (in test code) which did not properly convert from
URL path to file system path.

I think it would make sense to rename the Jenkins jobs to ensure all
the tests have a space in the path.

Possibly go further and try to introduce other special characters such
as $&+,:;=?@.

I've made a start with NET, which has built and tested OK.

WDYT?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[Gary Gregory]

Sounds reasonable but we need unit tests that also include spaces so that
we do rely on the build location as a test.

Gary

Post by sebb
IO-589 was accidentally found by trying to test in a path which
happened to contain a space.
This revealed a bug (in test code) which did not properly convert from
URL path to file system path.
I think it would make sense to rename the Jenkins jobs to ensure all
the tests have a space in the path.
Possibly go further and try to introduce other special characters such
I've made a start with NET, which has built and tested OK.
WDYT?
---------------------------------------------------------------------

[sebb]

Post by Gary Gregory
Sounds reasonable but we need unit tests that also include spaces so that
we do rely on the build location as a test.

Ideally, but I don't think that's possible in general.

For example, the IO-589 error happened because the classpath contained a space.
In this case, I guess it would have been possible to use a test file
whose name contained a space, but there may be other places where only
the classpath affects the result. I think that would be very difficult
to achieve without using a base path with a space in it.

Besides, one does not know in advance which tests are going to fail,
and therefore which tests need to be adjusted.

Post by Gary Gregory
Gary

Post by sebb
IO-589 was accidentally found by trying to test in a path which
happened to contain a space.
This revealed a bug (in test code) which did not properly convert from
URL path to file system path.
I think it would make sense to rename the Jenkins jobs to ensure all
the tests have a space in the path.
Possibly go further and try to introduce other special characters such
I've made a start with NET, which has built and tested OK.
WDYT?
---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

[Matt Sicker]

Can you make a folder like "Apache Commons" and then put all the Commons
jobs there? All of them will have a space in the name because of the parent
item name.

Post by sebb

Post by Gary Gregory
Sounds reasonable but we need unit tests that also include spaces so that
we do rely on the build location as a test.

Ideally, but I don't think that's possible in general.
For example, the IO-589 error happened because the classpath contained a space.
In this case, I guess it would have been possible to use a test file
whose name contained a space, but there may be other places where only
the classpath affects the result. I think that would be very difficult
to achieve without using a base path with a space in it.
Besides, one does not know in advance which tests are going to fail,
and therefore which tests need to be adjusted.

Post by Gary Gregory
Gary

Post by sebb
IO-589 was accidentally found by trying to test in a path which
happened to contain a space.
This revealed a bug (in test code) which did not properly convert from
URL path to file system path.
I think it would make sense to rename the Jenkins jobs to ensure all
the tests have a space in the path.
Possibly go further and try to introduce other special characters such
I've made a start with NET, which has built and tested OK.
WDYT?
---------------------------------------------------------------------

---------------------------------------------------------------------

[sebb]

Post by Matt Sicker
Can you make a folder like "Apache Commons" and then put all the Commons
jobs there? All of them will have a space in the name because of the parent
item name.

Nice idea.
"Apache Commons" will go against the existing convention.
But it might be acceptable to use "Commons components".

Post by Matt Sicker

Post by sebb

Post by Gary Gregory
Sounds reasonable but we need unit tests that also include spaces so that
we do rely on the build location as a test.

Ideally, but I don't think that's possible in general.
For example, the IO-589 error happened because the classpath contained a space.
In this case, I guess it would have been possible to use a test file
whose name contained a space, but there may be other places where only
the classpath affects the result. I think that would be very difficult
to achieve without using a base path with a space in it.
Besides, one does not know in advance which tests are going to fail,
and therefore which tests need to be adjusted.

Post by Gary Gregory
Gary

Post by sebb
IO-589 was accidentally found by trying to test in a path which
happened to contain a space.
This revealed a bug (in test code) which did not properly convert from
URL path to file system path.
I think it would make sense to rename the Jenkins jobs to ensure all
the tests have a space in the path.
Possibly go further and try to introduce other special characters such
I've made a start with NET, which has built and tested OK.
WDYT?
---------------------------------------------------------------------

---------------------------------------------------------------------

--

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org