[VOTE] Release Apache Commons Pool 2.6.1 based on RC1

Discussion:

Gary Gregory

2018-08-17 16:07:56 UTC

We have fixed one bug and updated optional dependencies since Apache
Commons Pool 2.6.0 was released, so I would like to release Apache Commons
Pool 2.6.1.

Apache Commons Pool 2.6.1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn
revision 28810)

The Git tag commons-pool-2.6.1-RC1 commit for this RC is
87c5dc14a967a70dd6e640395d4e842b021cdb8f which you can browse here:

https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=refs/tags/commons-pool-2.6.1-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1370/org/apache/commons/commons-pool2/2.6.1/

These are the Maven artifacts and their hashes in Nexus:

#Release SHA-256s
#Fri Aug 17 09:52:45 MDT 2018
commons-pool2-2.6.1-bin-zip.asc=c557973fdb9b917eb9bd3aea01db5ec1fd9ba81dc44de3ebbfcf0d30d3034457
commons-pool2-2.6.1-src-tar.gz=2c9a0cd9ca5d78321139abf66bf63bfdffab4e2c84949220efc836bab14925fb
commons-pool2-2.6.1-sources-java-source=9ec444a335d22398db9e2b8cff08651bb200b9a43be70603ee864a69698d70a1
commons-pool2-2.6.1-bin-tar.gz.asc=420d24c516e0a85461f4b723f26b3d1004f5891fe35eeb221438f1bebc529697
commons-pool2-2.6.1-src-zip=1039a4c88929549e5bb859443a02bf65679d94fd2722c8da2b0b116f737157ed
commons-pool2-2.6.1-bin-tar.gz=0e136611fcd6475cef0604c63901a64169af674e0a4bdc3eb6bdfd3f9974e189
commons-pool2-2.6.1-sources-jar.asc=b2d7c010ac17fa8c25b1a07c964774e520170b293d7280257dae730a7e6f273c
commons-pool2-2.6.1-src-tar.gz.asc=e5101573bb01aef53d69dc4161b0ce39629cc8a8029edf20eda8b591acba9ff0
commons-pool2-2.6.1-bin-zip=9c67aebafbbe9a6937f51fd88dee2c5bf2b2bb38391faf866cf2c0ec1d0144b2
commons-pool2-2.6.1-tests-jar.asc=1aff7c2d2482c8ad8abfbdbf5a5e6e2a2d6842f5ff3812b83de53dc78139101f
commons-pool2-2.6.1-javadoc-jar.asc=627815d18443a31a0965209c23f4c38f7a4f252983db8adbf5766c4e744070a4
commons-pool2-2.6.1-pom.asc=53303ad02b290d2d7740f4b322c8f3c3de1cab273fccd56afe487d161d827b3a
commons-pool2-2.6.1-jar.asc=48c226b9cecd68c3ff4b745ccc5279fceb3feb537483ed0c5b81ef29ae95ec4b
commons-pool2-2.6.1-tests-test-jar=54a0e606fbd469582b0b87ee61ebb5fd05b2895cd70649ce61b4a759528880a8
commons-pool2-2.6.1-javadoc-javadoc=246788c13a31585bf53d937ab5689d6553dd317b120919e65e0851ace5cd0e1e
commons-pool2-2.6.1-test-sources-java-source=6f898a2f047c79ce736f7dc9ea720b5d8dad9267d1e802f94aadb6a0a15f21ac
commons-pool2-2.6.1-test-sources-jar.asc=6f183311ea789f3146e0befb0e998c5a94af9dafd69af533aee9a5827caf89ba
commons-pool2-2.6.1-src-zip.asc=5d92f20734298fd84c910c689ea0dcb6ff7bc2ee1b7098c0871ac3273a5fba91

#Release SHA-512s
#Fri Aug 17 09:52:45 MDT 2018
commons-pool2-2.6.1-bin-zip.asc=adb02558de196b45370160773743d6302814ee78e0f70d9d14e8817fcd47d13b03e89afc33ae7c604a39eb449547e00575b7327b080b69c5061dc2c49de922a4
commons-pool2-2.6.1-src-tar.gz=3c29cf4ff089db2cb7be2795042eeb45ba883debc0605f2b0aa482a93def2ae2817bfcd11a92b4f57c51f32018cd508ff5baf81cc7769d2d22edc3393feba857
commons-pool2-2.6.1-sources-java-source=ed2473488503a2045209a14c9b16734045e72f2125a919da6096b581594f29ffd2073046b6604c2e8e4fb52093f08196c84e6db58c555d13f6d24c1af5287d89
commons-pool2-2.6.1-bin-tar.gz.asc=c88a49d30221a9fae91f26084a51bedb88bca7221336f5eda46469f02f9a4aebef72819dc2fa0e17b909eb3f6bedf762403585aa85b9d7e214a8604628c1b6d7
commons-pool2-2.6.1-src-zip=18a53fdfa2641eceae90152d0786b9ba0edee0d2d60af367b8b40232e30d512b37b6bef32a13512066bf5922f8383382972fd0697f176eca254fb5799c50a64b
commons-pool2-2.6.1-bin-tar.gz=d7a6e4b25eb98e17fe2f74230bc934163dcd00339adb753de6f29505d093224b55facb9b1ce6542bdd608d13e56d786e0f6d18e5325c6a9037cb5b84f699b0f5
commons-pool2-2.6.1-sources-jar.asc=a183c54291e14bbefb2bf2d56d39cb89e13d81f4b01fb772d962a85b9cc99cfe7123302474a9f636155593f55100312cde5e7e61ece955d3af63ce1a4fc3c5bf
commons-pool2-2.6.1-src-tar.gz.asc=9fce30e9a81bd485ba132cfb0b457dcd40519885873ff565e7bd739bc2735ce701494c81ad8083d65bff817a5df8c925e1cdd28cfc58a3a739290f1da02c7955
commons-pool2-2.6.1-bin-zip=ad4c21ff9f814598ab482e77f39a05659ccd765e833c94cf878eb69ed53a478f552c6483abd4308ee897cf1d3dfa78ef4c3f5197b7cb2c7596230d6d0c64e40a
commons-pool2-2.6.1-tests-jar.asc=871bd671ea515c599bd2f6e1dace4019a1ad7ea10db445fc3c9b63135c5b3ce48c692185257b0a0fa80068ca05163762ab59fa3bef18d59dcfbe87bb03d76c5c
commons-pool2-2.6.1-javadoc-jar.asc=75dfb23b30d4cd1cce5762666ed109922e957e581def3542949b6fcd722734196392ec03e852ff290a112016b6fb4633cecae4d1547a9ebd07638e8b573fd70b
commons-pool2-2.6.1-pom.asc=52d779d6bca3926dd07c95f2e858a329efe68c320e3dc44b94ab49adc4e63c23dfdb8c670b4ff774e2c96d066b09074f7fa10167a932c0e196a4ada906c6a83b
commons-pool2-2.6.1-jar.asc=a538e61847e36cd8d632eb21bf86e5dd5edfa9e742626774aacb9fd066f730e84557dcbec1a9f527479565431eaf3a69d8044908048bb14e143631c81fff7b8f
commons-pool2-2.6.1-tests-test-jar=21ec25a44afc8b75ade9ddc310a61d09e6f842b8eb6fc667f278cce23eec8246212288e25f34e614b38e9fbbbe1636fcec47e9acb89eb11ff8754ac3cdf1431f
commons-pool2-2.6.1-javadoc-javadoc=8d2fe40f88668b8dcfb913a154b63eae40036d124bfe15135cbfeb4a60fe0afa0421fb02076cd56a1aecd67ccaade4d5440e1acb300bd9370b356cc12d8ccf9a
commons-pool2-2.6.1-test-sources-java-source=fed69abeded0d585d6c6185db30946eb736f10ba58a596169c13c5c075828d4db44606059b9e1b7fee02ca35fe6c4e7e13bdab56c3d888a6f9b7a1957f323803
commons-pool2-2.6.1-test-sources-jar.asc=bd4462f6efd6ccf5355405b84c503c59f15cf682a7d523fbe8dbdfb6f64d53d60fa294ba138c60ce487f17aa76efadb4f73f8f7875d4c26b7b2adaa641d1cd27
commons-pool2-2.6.1-src-zip.asc=ffbe6ad4b2dc8f0d278f4a4c1d5dfeec2a9dfb629d5481e6b73739e767f54ed29ad829bdbefc638acfae567a501945c8d021d50ee5af53d413d8ef206cb29629

(no need for .asc hashes!)

I have tested this with 'mvn clean package site deploy' using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Details of changes since 2.6.0 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/changes-report.html

Site:
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site
(note some *relative* links are broken and the 2.6.1 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 2.6.0):

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/clirr-report.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/rat-report.html

KEYS:
https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

Bruno P. Kinoshita

2018-08-18 05:30:05 UTC

Permalink

[ X ] +1 Release these artifacts

Not much time to review signatures, but tested the build with `mvn clean test site` against commit sha from git

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00)
Maven home: /opt/apache-maven-3.5.2
Java version: 1.8.0_181, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-133-generic", arch: "amd64", family: "unix"

Building OK. We introduced some minor issues in PMD, and checkstyle. Would be nice if someone had some time to fix some of these issues. There should be a few ones quite simple to tackle.

Also no coverage report - at least I couldn't find cobertura o jacoco reports. I wonder if that'd be something easy to add after the release. Maybe just a few lines in pom.xml's reporting section?

Thanks for RM'ing.

Cheers
Bruno

________________________________
From: Gary Gregory <***@apache.org>
To: Commons Developers List <***@commons.apache.org>
Sent: Saturday, 18 August 2018 4:08 AM
Subject: [VOTE] Release Apache Commons Pool 2.6.1 based on RC1

We have fixed one bug and updated optional dependencies since Apache

Commons Pool 2.6.0 was released, so I would like to release Apache Commons

Pool 2.6.1.

Apache Commons Pool 2.6.1 RC1 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn

revision 28810)

The Git tag commons-pool-2.6.1-RC1 commit for this RC is

87c5dc14a967a70dd6e640395d4e842b021cdb8f which you can browse here:

https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=refs/tags/commons-pool-2.6.1-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1370/org/apache/commons/commons-pool2/2.6.1/

These are the Maven artifacts and their hashes in Nexus:

#Release SHA-256s

#Fri Aug 17 09:52:45 MDT 2018

commons-pool2-2.6.1-bin-zip.asc=c557973fdb9b917eb9bd3aea01db5ec1fd9ba81dc44de3ebbfcf0d30d3034457

commons-pool2-2.6.1-src-tar.gz=2c9a0cd9ca5d78321139abf66bf63bfdffab4e2c84949220efc836bab14925fb

commons-pool2-2.6.1-sources-java-source=9ec444a335d22398db9e2b8cff08651bb200b9a43be70603ee864a69698d70a1

commons-pool2-2.6.1-bin-tar.gz.asc=420d24c516e0a85461f4b723f26b3d1004f5891fe35eeb221438f1bebc529697

commons-pool2-2.6.1-src-zip=1039a4c88929549e5bb859443a02bf65679d94fd2722c8da2b0b116f737157ed

commons-pool2-2.6.1-bin-tar.gz=0e136611fcd6475cef0604c63901a64169af674e0a4bdc3eb6bdfd3f9974e189

commons-pool2-2.6.1-sources-jar.asc=b2d7c010ac17fa8c25b1a07c964774e520170b293d7280257dae730a7e6f273c

commons-pool2-2.6.1-src-tar.gz.asc=e5101573bb01aef53d69dc4161b0ce39629cc8a8029edf20eda8b591acba9ff0

commons-pool2-2.6.1-bin-zip=9c67aebafbbe9a6937f51fd88dee2c5bf2b2bb38391faf866cf2c0ec1d0144b2

commons-pool2-2.6.1-tests-jar.asc=1aff7c2d2482c8ad8abfbdbf5a5e6e2a2d6842f5ff3812b83de53dc78139101f

commons-pool2-2.6.1-javadoc-jar.asc=627815d18443a31a0965209c23f4c38f7a4f252983db8adbf5766c4e744070a4

commons-pool2-2.6.1-pom.asc=53303ad02b290d2d7740f4b322c8f3c3de1cab273fccd56afe487d161d827b3a

commons-pool2-2.6.1-jar.asc=48c226b9cecd68c3ff4b745ccc5279fceb3feb537483ed0c5b81ef29ae95ec4b

commons-pool2-2.6.1-tests-test-jar=54a0e606fbd469582b0b87ee61ebb5fd05b2895cd70649ce61b4a759528880a8

commons-pool2-2.6.1-javadoc-javadoc=246788c13a31585bf53d937ab5689d6553dd317b120919e65e0851ace5cd0e1e

commons-pool2-2.6.1-test-sources-java-source=6f898a2f047c79ce736f7dc9ea720b5d8dad9267d1e802f94aadb6a0a15f21ac

commons-pool2-2.6.1-test-sources-jar.asc=6f183311ea789f3146e0befb0e998c5a94af9dafd69af533aee9a5827caf89ba

commons-pool2-2.6.1-src-zip.asc=5d92f20734298fd84c910c689ea0dcb6ff7bc2ee1b7098c0871ac3273a5fba91

#Release SHA-512s

#Fri Aug 17 09:52:45 MDT 2018

commons-pool2-2.6.1-bin-zip.asc=adb02558de196b45370160773743d6302814ee78e0f70d9d14e8817fcd47d13b03e89afc33ae7c604a39eb449547e00575b7327b080b69c5061dc2c49de922a4

commons-pool2-2.6.1-src-tar.gz=3c29cf4ff089db2cb7be2795042eeb45ba883debc0605f2b0aa482a93def2ae2817bfcd11a92b4f57c51f32018cd508ff5baf81cc7769d2d22edc3393feba857

commons-pool2-2.6.1-sources-java-source=ed2473488503a2045209a14c9b16734045e72f2125a919da6096b581594f29ffd2073046b6604c2e8e4fb52093f08196c84e6db58c555d13f6d24c1af5287d89

commons-pool2-2.6.1-bin-tar.gz.asc=c88a49d30221a9fae91f26084a51bedb88bca7221336f5eda46469f02f9a4aebef72819dc2fa0e17b909eb3f6bedf762403585aa85b9d7e214a8604628c1b6d7

commons-pool2-2.6.1-src-zip=18a53fdfa2641eceae90152d0786b9ba0edee0d2d60af367b8b40232e30d512b37b6bef32a13512066bf5922f8383382972fd0697f176eca254fb5799c50a64b

commons-pool2-2.6.1-bin-tar.gz=d7a6e4b25eb98e17fe2f74230bc934163dcd00339adb753de6f29505d093224b55facb9b1ce6542bdd608d13e56d786e0f6d18e5325c6a9037cb5b84f699b0f5

commons-pool2-2.6.1-sources-jar.asc=a183c54291e14bbefb2bf2d56d39cb89e13d81f4b01fb772d962a85b9cc99cfe7123302474a9f636155593f55100312cde5e7e61ece955d3af63ce1a4fc3c5bf

commons-pool2-2.6.1-src-tar.gz.asc=9fce30e9a81bd485ba132cfb0b457dcd40519885873ff565e7bd739bc2735ce701494c81ad8083d65bff817a5df8c925e1cdd28cfc58a3a739290f1da02c7955

commons-pool2-2.6.1-bin-zip=ad4c21ff9f814598ab482e77f39a05659ccd765e833c94cf878eb69ed53a478f552c6483abd4308ee897cf1d3dfa78ef4c3f5197b7cb2c7596230d6d0c64e40a

commons-pool2-2.6.1-tests-jar.asc=871bd671ea515c599bd2f6e1dace4019a1ad7ea10db445fc3c9b63135c5b3ce48c692185257b0a0fa80068ca05163762ab59fa3bef18d59dcfbe87bb03d76c5c

commons-pool2-2.6.1-javadoc-jar.asc=75dfb23b30d4cd1cce5762666ed109922e957e581def3542949b6fcd722734196392ec03e852ff290a112016b6fb4633cecae4d1547a9ebd07638e8b573fd70b

commons-pool2-2.6.1-pom.asc=52d779d6bca3926dd07c95f2e858a329efe68c320e3dc44b94ab49adc4e63c23dfdb8c670b4ff774e2c96d066b09074f7fa10167a932c0e196a4ada906c6a83b

commons-pool2-2.6.1-jar.asc=a538e61847e36cd8d632eb21bf86e5dd5edfa9e742626774aacb9fd066f730e84557dcbec1a9f527479565431eaf3a69d8044908048bb14e143631c81fff7b8f

commons-pool2-2.6.1-tests-test-jar=21ec25a44afc8b75ade9ddc310a61d09e6f842b8eb6fc667f278cce23eec8246212288e25f34e614b38e9fbbbe1636fcec47e9acb89eb11ff8754ac3cdf1431f

commons-pool2-2.6.1-javadoc-javadoc=8d2fe40f88668b8dcfb913a154b63eae40036d124bfe15135cbfeb4a60fe0afa0421fb02076cd56a1aecd67ccaade4d5440e1acb300bd9370b356cc12d8ccf9a

commons-pool2-2.6.1-test-sources-java-source=fed69abeded0d585d6c6185db30946eb736f10ba58a596169c13c5c075828d4db44606059b9e1b7fee02ca35fe6c4e7e13bdab56c3d888a6f9b7a1957f323803

commons-pool2-2.6.1-test-sources-jar.asc=bd4462f6efd6ccf5355405b84c503c59f15cf682a7d523fbe8dbdfb6f64d53d60fa294ba138c60ce487f17aa76efadb4f73f8f7875d4c26b7b2adaa641d1cd27

commons-pool2-2.6.1-src-zip.asc=ffbe6ad4b2dc8f0d278f4a4c1d5dfeec2a9dfb629d5481e6b73739e767f54ed29ad829bdbefc638acfae567a501945c8d021d50ee5af53d413d8ef206cb29629

(no need for .asc hashes!)

I have tested this with 'mvn clean package site deploy' using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;

2018-06-17T12:33:14-06:00)

Maven home: C:\Java\apache-maven-3.5.4\bin\..

Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program

Files\Java\jdk1.8.0_181\jre

Default locale: en_US, platform encoding: Cp1252

OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Details of changes since 2.6.0 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site

(note some *relative* links are broken and the 2.6.1 directories are

not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 2.6.0):

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/clirr-report.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/rat-report.html

KEYS:

https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.

This vote will close no sooner that 72 hours from now.

[ ] +1 Release these artifacts

[ ] +0 OK, but...

[ ] -0 OK, but really should fix...

[ ] -1 I oppose this release because...

Thank you,

Gary Gregory,

Release Manager (using key 86fdc7e2a11262cb)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Gary Gregory

2018-08-20 19:05:41 UTC

Permalink

May I have more reviews please?

Gary

Post by Gary Gregory
We have fixed one bug and updated optional dependencies since Apache
Commons Pool 2.6.0 was released, so I would like to release Apache Commons
Pool 2.6.1.
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn
revision 28810)
The Git tag commons-pool-2.6.1-RC1 commit for this RC is
https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=refs/tags/commons-pool-2.6.1-RC1
https://repository.apache.org/content/repositories/orgapachecommons-1370/org/apache/commons/commons-pool2/2.6.1/
#Release SHA-256s
#Fri Aug 17 09:52:45 MDT 2018
commons-pool2-2.6.1-bin-zip.asc=c557973fdb9b917eb9bd3aea01db5ec1fd9ba81dc44de3ebbfcf0d30d3034457
commons-pool2-2.6.1-src-tar.gz=2c9a0cd9ca5d78321139abf66bf63bfdffab4e2c84949220efc836bab14925fb
commons-pool2-2.6.1-sources-java-source=9ec444a335d22398db9e2b8cff08651bb200b9a43be70603ee864a69698d70a1
commons-pool2-2.6.1-bin-tar.gz.asc=420d24c516e0a85461f4b723f26b3d1004f5891fe35eeb221438f1bebc529697
commons-pool2-2.6.1-src-zip=1039a4c88929549e5bb859443a02bf65679d94fd2722c8da2b0b116f737157ed
commons-pool2-2.6.1-bin-tar.gz=0e136611fcd6475cef0604c63901a64169af674e0a4bdc3eb6bdfd3f9974e189
commons-pool2-2.6.1-sources-jar.asc=b2d7c010ac17fa8c25b1a07c964774e520170b293d7280257dae730a7e6f273c
commons-pool2-2.6.1-src-tar.gz.asc=e5101573bb01aef53d69dc4161b0ce39629cc8a8029edf20eda8b591acba9ff0
commons-pool2-2.6.1-bin-zip=9c67aebafbbe9a6937f51fd88dee2c5bf2b2bb38391faf866cf2c0ec1d0144b2
commons-pool2-2.6.1-tests-jar.asc=1aff7c2d2482c8ad8abfbdbf5a5e6e2a2d6842f5ff3812b83de53dc78139101f
commons-pool2-2.6.1-javadoc-jar.asc=627815d18443a31a0965209c23f4c38f7a4f252983db8adbf5766c4e744070a4
commons-pool2-2.6.1-pom.asc=53303ad02b290d2d7740f4b322c8f3c3de1cab273fccd56afe487d161d827b3a
commons-pool2-2.6.1-jar.asc=48c226b9cecd68c3ff4b745ccc5279fceb3feb537483ed0c5b81ef29ae95ec4b
commons-pool2-2.6.1-tests-test-jar=54a0e606fbd469582b0b87ee61ebb5fd05b2895cd70649ce61b4a759528880a8
commons-pool2-2.6.1-javadoc-javadoc=246788c13a31585bf53d937ab5689d6553dd317b120919e65e0851ace5cd0e1e
commons-pool2-2.6.1-test-sources-java-source=6f898a2f047c79ce736f7dc9ea720b5d8dad9267d1e802f94aadb6a0a15f21ac
commons-pool2-2.6.1-test-sources-jar.asc=6f183311ea789f3146e0befb0e998c5a94af9dafd69af533aee9a5827caf89ba
commons-pool2-2.6.1-src-zip.asc=5d92f20734298fd84c910c689ea0dcb6ff7bc2ee1b7098c0871ac3273a5fba91
#Release SHA-512s
#Fri Aug 17 09:52:45 MDT 2018
commons-pool2-2.6.1-bin-zip.asc=adb02558de196b45370160773743d6302814ee78e0f70d9d14e8817fcd47d13b03e89afc33ae7c604a39eb449547e00575b7327b080b69c5061dc2c49de922a4
commons-pool2-2.6.1-src-tar.gz=3c29cf4ff089db2cb7be2795042eeb45ba883debc0605f2b0aa482a93def2ae2817bfcd11a92b4f57c51f32018cd508ff5baf81cc7769d2d22edc3393feba857
commons-pool2-2.6.1-sources-java-source=ed2473488503a2045209a14c9b16734045e72f2125a919da6096b581594f29ffd2073046b6604c2e8e4fb52093f08196c84e6db58c555d13f6d24c1af5287d89
commons-pool2-2.6.1-bin-tar.gz.asc=c88a49d30221a9fae91f26084a51bedb88bca7221336f5eda46469f02f9a4aebef72819dc2fa0e17b909eb3f6bedf762403585aa85b9d7e214a8604628c1b6d7
commons-pool2-2.6.1-src-zip=18a53fdfa2641eceae90152d0786b9ba0edee0d2d60af367b8b40232e30d512b37b6bef32a13512066bf5922f8383382972fd0697f176eca254fb5799c50a64b
commons-pool2-2.6.1-bin-tar.gz=d7a6e4b25eb98e17fe2f74230bc934163dcd00339adb753de6f29505d093224b55facb9b1ce6542bdd608d13e56d786e0f6d18e5325c6a9037cb5b84f699b0f5
commons-pool2-2.6.1-sources-jar.asc=a183c54291e14bbefb2bf2d56d39cb89e13d81f4b01fb772d962a85b9cc99cfe7123302474a9f636155593f55100312cde5e7e61ece955d3af63ce1a4fc3c5bf
commons-pool2-2.6.1-src-tar.gz.asc=9fce30e9a81bd485ba132cfb0b457dcd40519885873ff565e7bd739bc2735ce701494c81ad8083d65bff817a5df8c925e1cdd28cfc58a3a739290f1da02c7955
commons-pool2-2.6.1-bin-zip=ad4c21ff9f814598ab482e77f39a05659ccd765e833c94cf878eb69ed53a478f552c6483abd4308ee897cf1d3dfa78ef4c3f5197b7cb2c7596230d6d0c64e40a
commons-pool2-2.6.1-tests-jar.asc=871bd671ea515c599bd2f6e1dace4019a1ad7ea10db445fc3c9b63135c5b3ce48c692185257b0a0fa80068ca05163762ab59fa3bef18d59dcfbe87bb03d76c5c
commons-pool2-2.6.1-javadoc-jar.asc=75dfb23b30d4cd1cce5762666ed109922e957e581def3542949b6fcd722734196392ec03e852ff290a112016b6fb4633cecae4d1547a9ebd07638e8b573fd70b
commons-pool2-2.6.1-pom.asc=52d779d6bca3926dd07c95f2e858a329efe68c320e3dc44b94ab49adc4e63c23dfdb8c670b4ff774e2c96d066b09074f7fa10167a932c0e196a4ada906c6a83b
commons-pool2-2.6.1-jar.asc=a538e61847e36cd8d632eb21bf86e5dd5edfa9e742626774aacb9fd066f730e84557dcbec1a9f527479565431eaf3a69d8044908048bb14e143631c81fff7b8f
commons-pool2-2.6.1-tests-test-jar=21ec25a44afc8b75ade9ddc310a61d09e6f842b8eb6fc667f278cce23eec8246212288e25f34e614b38e9fbbbe1636fcec47e9acb89eb11ff8754ac3cdf1431f
commons-pool2-2.6.1-javadoc-javadoc=8d2fe40f88668b8dcfb913a154b63eae40036d124bfe15135cbfeb4a60fe0afa0421fb02076cd56a1aecd67ccaade4d5440e1acb300bd9370b356cc12d8ccf9a
commons-pool2-2.6.1-test-sources-java-source=fed69abeded0d585d6c6185db30946eb736f10ba58a596169c13c5c075828d4db44606059b9e1b7fee02ca35fe6c4e7e13bdab56c3d888a6f9b7a1957f323803
commons-pool2-2.6.1-test-sources-jar.asc=bd4462f6efd6ccf5355405b84c503c59f15cf682a7d523fbe8dbdfb6f64d53d60fa294ba138c60ce487f17aa76efadb4f73f8f7875d4c26b7b2adaa641d1cd27
commons-pool2-2.6.1-src-zip.asc=ffbe6ad4b2dc8f0d278f4a4c1d5dfeec2a9dfb629d5481e6b73739e767f54ed29ad829bdbefc638acfae567a501945c8d021d50ee5af53d413d8ef206cb29629
(no need for .asc hashes!)
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/changes-report.html
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site
(note some *relative* links are broken and the 2.6.1 directories are
not yet created - these will be OK once the site is deployed.)
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/clirr-report.html
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/rat-report.html
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

Benedikt Ritter

2018-08-21 07:06:01 UTC

Permalink

Hello Gary,

-1, I there are several issues that we need to fix this before we can
release 2.6.1.

I think the RELEASE NOTES need more work:

"The Apache Commons Pool team is pleased to announce the release of Apache
Commons Pool 2.6.1-SNAPSHOT."
"No client code changes are required to migrate from versions 2.0-2.3 to
version 2.4.3." - what about migration to 2.6.1?
"Version 2 requires JDK level 1.6 or above" - Website states that Java 7 is
required.

The release tag is not signed:
~/w/a/r/p/commons-pool git:(master) > git tag -v commons-pool-2.6.1-RC1
object 87c5dc14a967a70dd6e640395d4e842b021cdb8f
type commit
tag commons-pool-2.6.1-RC1
tagger Gary Gregory <***@gmail.com> 1534517006 -0600

Tag Apache Commons Pool release 2.6.1 RC1
error: no signature found

There are various differences between to release tag in git and the
contents of the src archive:
~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src
Only in commons-pool: .git
Only in commons-pool: .gitignore
Only in commons-pool: .travis.yml
Only in commons-pool: CONTRIBUTING.md
Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt differ
Only in commons-pool: README.md
Files commons-pool/RELEASE-NOTES.txt and
commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ
Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ
Only in commons-pool: pool-RC.sh
Only in commons-pool: pool-pre-RC.sh
Only in commons-pool: pool-release.sh
Only in commons-pool/src: assembly
Files commons-pool/src/changes/changes.xml and
commons-pool2-2.6.1-src/src/changes/changes.xml differ
Files commons-pool/src/site/resources/download_pool.cgi and
commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ
Files commons-pool/src/site/site.xml and
commons-pool2-2.6.1-src/src/site/site.xml differ
Files commons-pool/src/site/xdoc/index.xml and
commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ
Files commons-pool/src/site/xdoc/issue-tracking.xml and
commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ

Some of them are okay (e.g. git files) but others are not (like changes.xml)

The build works on my machine using:
~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T20:33:14+02:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 1.8.0_161, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"

Regards,
Benedikt

Gary Gregory

2018-08-22 14:03:42 UTC

Permalink

WRT signing tags, ATM, I cannot git's -s option to work with GPG on
Windows. Any clues?

Gary

Post by Benedikt Ritter
Hello Gary,
-1, I there are several issues that we need to fix this before we can
release 2.6.1.
"The Apache Commons Pool team is pleased to announce the release of Apache
Commons Pool 2.6.1-SNAPSHOT."
"No client code changes are required to migrate from versions 2.0-2.3 to
version 2.4.3." - what about migration to 2.6.1?
"Version 2 requires JDK level 1.6 or above" - Website states that Java 7 is
required.
~/w/a/r/p/commons-pool git:(master) > git tag -v commons-pool-2.6.1-RC1
object 87c5dc14a967a70dd6e640395d4e842b021cdb8f
type commit
tag commons-pool-2.6.1-RC1
Tag Apache Commons Pool release 2.6.1 RC1
error: no signature found
There are various differences between to release tag in git and the
~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src
Only in commons-pool: .git
Only in commons-pool: .gitignore
Only in commons-pool: .travis.yml
Only in commons-pool: CONTRIBUTING.md
Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt differ
Only in commons-pool: README.md
Files commons-pool/RELEASE-NOTES.txt and
commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ
Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ
Only in commons-pool: pool-RC.sh
Only in commons-pool: pool-pre-RC.sh
Only in commons-pool: pool-release.sh
Only in commons-pool/src: assembly
Files commons-pool/src/changes/changes.xml and
commons-pool2-2.6.1-src/src/changes/changes.xml differ
Files commons-pool/src/site/resources/download_pool.cgi and
commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ
Files commons-pool/src/site/site.xml and
commons-pool2-2.6.1-src/src/site/site.xml differ
Files commons-pool/src/site/xdoc/index.xml and
commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ
Files commons-pool/src/site/xdoc/issue-tracking.xml and
commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ
Some of them are okay (e.g. git files) but others are not (like changes.xml)
~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T20:33:14+02:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
Regards,
Benedikt
Am Fr., 17. Aug. 2018 um 18:08 Uhr schrieb Gary Gregory <

Post by Gary Gregory
We have fixed one bug and updated optional dependencies since Apache
Commons Pool 2.6.0 was released, so I would like to release Apache

Commons

Post by Gary Gregory
Pool 2.6.1.
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn
revision 28810)
The Git tag commons-pool-2.6.1-RC1 commit for this RC is

https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=refs/tags/commons-pool-2.6.1-RC1
https://repository.apache.org/content/repositories/orgapachecommons-1370/org/apache/commons/commons-pool2/2.6.1/

Post by Gary Gregory
#Release SHA-256s
#Fri Aug 17 09:52:45 MDT 2018

commons-pool2-2.6.1-bin-zip.asc=c557973fdb9b917eb9bd3aea01db5ec1fd9ba81dc44de3ebbfcf0d30d3034457
commons-pool2-2.6.1-src-tar.gz=2c9a0cd9ca5d78321139abf66bf63bfdffab4e2c84949220efc836bab14925fb
commons-pool2-2.6.1-sources-java-source=9ec444a335d22398db9e2b8cff08651bb200b9a43be70603ee864a69698d70a1
commons-pool2-2.6.1-bin-tar.gz.asc=420d24c516e0a85461f4b723f26b3d1004f5891fe35eeb221438f1bebc529697
commons-pool2-2.6.1-src-zip=1039a4c88929549e5bb859443a02bf65679d94fd2722c8da2b0b116f737157ed
commons-pool2-2.6.1-bin-tar.gz=0e136611fcd6475cef0604c63901a64169af674e0a4bdc3eb6bdfd3f9974e189
commons-pool2-2.6.1-sources-jar.asc=b2d7c010ac17fa8c25b1a07c964774e520170b293d7280257dae730a7e6f273c
commons-pool2-2.6.1-src-tar.gz.asc=e5101573bb01aef53d69dc4161b0ce39629cc8a8029edf20eda8b591acba9ff0
commons-pool2-2.6.1-bin-zip=9c67aebafbbe9a6937f51fd88dee2c5bf2b2bb38391faf866cf2c0ec1d0144b2
commons-pool2-2.6.1-tests-jar.asc=1aff7c2d2482c8ad8abfbdbf5a5e6e2a2d6842f5ff3812b83de53dc78139101f
commons-pool2-2.6.1-javadoc-jar.asc=627815d18443a31a0965209c23f4c38f7a4f252983db8adbf5766c4e744070a4
commons-pool2-2.6.1-pom.asc=53303ad02b290d2d7740f4b322c8f3c3de1cab273fccd56afe487d161d827b3a
commons-pool2-2.6.1-jar.asc=48c226b9cecd68c3ff4b745ccc5279fceb3feb537483ed0c5b81ef29ae95ec4b
commons-pool2-2.6.1-tests-test-jar=54a0e606fbd469582b0b87ee61ebb5fd05b2895cd70649ce61b4a759528880a8
commons-pool2-2.6.1-javadoc-javadoc=246788c13a31585bf53d937ab5689d6553dd317b120919e65e0851ace5cd0e1e
commons-pool2-2.6.1-test-sources-java-source=6f898a2f047c79ce736f7dc9ea720b5d8dad9267d1e802f94aadb6a0a15f21ac
commons-pool2-2.6.1-test-sources-jar.asc=6f183311ea789f3146e0befb0e998c5a94af9dafd69af533aee9a5827caf89ba
commons-pool2-2.6.1-src-zip.asc=5d92f20734298fd84c910c689ea0dcb6ff7bc2ee1b7098c0871ac3273a5fba91

Post by Gary Gregory
#Release SHA-512s
#Fri Aug 17 09:52:45 MDT 2018

commons-pool2-2.6.1-bin-zip.asc=adb02558de196b45370160773743d6302814ee78e0f70d9d14e8817fcd47d13b03e89afc33ae7c604a39eb449547e00575b7327b080b69c5061dc2c49de922a4
commons-pool2-2.6.1-src-tar.gz=3c29cf4ff089db2cb7be2795042eeb45ba883debc0605f2b0aa482a93def2ae2817bfcd11a92b4f57c51f32018cd508ff5baf81cc7769d2d22edc3393feba857
commons-pool2-2.6.1-sources-java-source=ed2473488503a2045209a14c9b16734045e72f2125a919da6096b581594f29ffd2073046b6604c2e8e4fb52093f08196c84e6db58c555d13f6d24c1af5287d89
commons-pool2-2.6.1-bin-tar.gz.asc=c88a49d30221a9fae91f26084a51bedb88bca7221336f5eda46469f02f9a4aebef72819dc2fa0e17b909eb3f6bedf762403585aa85b9d7e214a8604628c1b6d7
commons-pool2-2.6.1-src-zip=18a53fdfa2641eceae90152d0786b9ba0edee0d2d60af367b8b40232e30d512b37b6bef32a13512066bf5922f8383382972fd0697f176eca254fb5799c50a64b
commons-pool2-2.6.1-bin-tar.gz=d7a6e4b25eb98e17fe2f74230bc934163dcd00339adb753de6f29505d093224b55facb9b1ce6542bdd608d13e56d786e0f6d18e5325c6a9037cb5b84f699b0f5
commons-pool2-2.6.1-sources-jar.asc=a183c54291e14bbefb2bf2d56d39cb89e13d81f4b01fb772d962a85b9cc99cfe7123302474a9f636155593f55100312cde5e7e61ece955d3af63ce1a4fc3c5bf
commons-pool2-2.6.1-src-tar.gz.asc=9fce30e9a81bd485ba132cfb0b457dcd40519885873ff565e7bd739bc2735ce701494c81ad8083d65bff817a5df8c925e1cdd28cfc58a3a739290f1da02c7955
commons-pool2-2.6.1-bin-zip=ad4c21ff9f814598ab482e77f39a05659ccd765e833c94cf878eb69ed53a478f552c6483abd4308ee897cf1d3dfa78ef4c3f5197b7cb2c7596230d6d0c64e40a
commons-pool2-2.6.1-tests-jar.asc=871bd671ea515c599bd2f6e1dace4019a1ad7ea10db445fc3c9b63135c5b3ce48c692185257b0a0fa80068ca05163762ab59fa3bef18d59dcfbe87bb03d76c5c
commons-pool2-2.6.1-javadoc-jar.asc=75dfb23b30d4cd1cce5762666ed109922e957e581def3542949b6fcd722734196392ec03e852ff290a112016b6fb4633cecae4d1547a9ebd07638e8b573fd70b
commons-pool2-2.6.1-pom.asc=52d779d6bca3926dd07c95f2e858a329efe68c320e3dc44b94ab49adc4e63c23dfdb8c670b4ff774e2c96d066b09074f7fa10167a932c0e196a4ada906c6a83b
commons-pool2-2.6.1-jar.asc=a538e61847e36cd8d632eb21bf86e5dd5edfa9e742626774aacb9fd066f730e84557dcbec1a9f527479565431eaf3a69d8044908048bb14e143631c81fff7b8f
commons-pool2-2.6.1-tests-test-jar=21ec25a44afc8b75ade9ddc310a61d09e6f842b8eb6fc667f278cce23eec8246212288e25f34e614b38e9fbbbe1636fcec47e9acb89eb11ff8754ac3cdf1431f
commons-pool2-2.6.1-javadoc-javadoc=8d2fe40f88668b8dcfb913a154b63eae40036d124bfe15135cbfeb4a60fe0afa0421fb02076cd56a1aecd67ccaade4d5440e1acb300bd9370b356cc12d8ccf9a
commons-pool2-2.6.1-test-sources-java-source=fed69abeded0d585d6c6185db30946eb736f10ba58a596169c13c5c075828d4db44606059b9e1b7fee02ca35fe6c4e7e13bdab56c3d888a6f9b7a1957f323803
commons-pool2-2.6.1-test-sources-jar.asc=bd4462f6efd6ccf5355405b84c503c59f15cf682a7d523fbe8dbdfb6f64d53d60fa294ba138c60ce487f17aa76efadb4f73f8f7875d4c26b7b2adaa641d1cd27
commons-pool2-2.6.1-src-zip.asc=ffbe6ad4b2dc8f0d278f4a4c1d5dfeec2a9dfb629d5481e6b73739e767f54ed29ad829bdbefc638acfae567a501945c8d021d50ee5af53d413d8ef206cb29629

Post by Gary Gregory
(no need for .asc hashes!)
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/changes-report.html

Post by Gary Gregory
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site
(note some *relative* links are broken and the 2.6.1 directories are
not yet created - these will be OK once the site is deployed.)

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/clirr-report.html
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/rat-report.html

Post by Gary Gregory
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

Benedikt Ritter

2018-08-22 19:14:05 UTC

Permalink

Hi Gary,
Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory <

Post by Gary Gregory
WRT signing tags, ATM, I cannot git's -s option to work with GPG on
Windows. Any clues?

Sorry, I'm on macOS. For that to work I needed to have the gpg-agent
running. But I don't know whether this is a unix thing.

The tag signing alone would not cause me to vote -1. I can live with an
unsigned tag. What really needs to be fixed are the differences between src
distribution and release tag in my opinion. I'll have time on Saturday to
have a look into that if you don't get to it until then.

Regards,
Benedikt

Post by Gary Gregory
Gary

Post by Benedikt Ritter
Hello Gary,
-1, I there are several issues that we need to fix this before we can
release 2.6.1.
"The Apache Commons Pool team is pleased to announce the release of

Apache

Post by Benedikt Ritter
Commons Pool 2.6.1-SNAPSHOT."
"No client code changes are required to migrate from versions 2.0-2.3 to
version 2.4.3." - what about migration to 2.6.1?
"Version 2 requires JDK level 1.6 or above" - Website states that Java 7

Post by Benedikt Ritter
required.
~/w/a/r/p/commons-pool git:(master) > git tag -v commons-pool-2.6.1-RC1
object 87c5dc14a967a70dd6e640395d4e842b021cdb8f
type commit
tag commons-pool-2.6.1-RC1
Tag Apache Commons Pool release 2.6.1 RC1
error: no signature found
There are various differences between to release tag in git and the
~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src
Only in commons-pool: .git
Only in commons-pool: .gitignore
Only in commons-pool: .travis.yml
Only in commons-pool: CONTRIBUTING.md
Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt

differ

Post by Benedikt Ritter
Only in commons-pool: README.md
Files commons-pool/RELEASE-NOTES.txt and
commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ
Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ
Only in commons-pool: pool-RC.sh
Only in commons-pool: pool-pre-RC.sh
Only in commons-pool: pool-release.sh
Only in commons-pool/src: assembly
Files commons-pool/src/changes/changes.xml and
commons-pool2-2.6.1-src/src/changes/changes.xml differ
Files commons-pool/src/site/resources/download_pool.cgi and
commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ
Files commons-pool/src/site/site.xml and
commons-pool2-2.6.1-src/src/site/site.xml differ
Files commons-pool/src/site/xdoc/index.xml and
commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ
Files commons-pool/src/site/xdoc/issue-tracking.xml and
commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ
Some of them are okay (e.g. git files) but others are not (like changes.xml)
~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T20:33:14+02:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
Regards,
Benedikt
Am Fr., 17. Aug. 2018 um 18:08 Uhr schrieb Gary Gregory <

Post by Gary Gregory
We have fixed one bug and updated optional dependencies since Apache
Commons Pool 2.6.0 was released, so I would like to release Apache

Commons

Post by Gary Gregory
Pool 2.6.1.
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn
revision 28810)
The Git tag commons-pool-2.6.1-RC1 commit for this RC is

Post by Benedikt Ritter

Post by Gary Gregory
#Release SHA-256s
#Fri Aug 17 09:52:45 MDT 2018

Post by Benedikt Ritter

Post by Gary Gregory
#Release SHA-512s
#Fri Aug 17 09:52:45 MDT 2018

Post by Benedikt Ritter

Post by Gary Gregory
(no need for .asc hashes!)
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..

C:\Program

Post by Benedikt Ritter

Post by Gary Gregory
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252

"windows"
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/changes-report.html

Post by Benedikt Ritter

Post by Gary Gregory
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site
(note some *relative* links are broken and the 2.6.1 directories

are

Post by Benedikt Ritter

Post by Gary Gregory
not yet created - these will be OK once the site is deployed.)

https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/clirr-report.html
https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1/site/rat-report.html

Post by Benedikt Ritter

Gary Gregory

2018-08-23 13:39:11 UTC

Permalink

Post by Benedikt Ritter
Hi Gary,
Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory <

Post by Gary Gregory
WRT signing tags, ATM, I cannot git's -s option to work with GPG on
Windows. Any clues?

Sorry, I'm on macOS. For that to work I needed to have the gpg-agent
running. But I don't know whether this is a unix thing.
The tag signing alone would not cause me to vote -1. I can live with an
unsigned tag. What really needs to be fixed are the differences between src
distribution and release tag in my opinion. I'll have time on Saturday to
have a look into that if you don't get to it until then.

I welcome the help :-) Quite busy at work.

Gary

Post by Benedikt Ritter
Regards,
Benedikt

Post by Gary Gregory
Gary

Post by Benedikt Ritter
Hello Gary,
-1, I there are several issues that we need to fix this before we can
release 2.6.1.
"The Apache Commons Pool team is pleased to announce the release of

Apache

Post by Benedikt Ritter
Commons Pool 2.6.1-SNAPSHOT."
"No client code changes are required to migrate from versions 2.0-2.3