[Vote] RC2 for releasing Commons RNG v1.2

Discussion:

Gilles

2018-12-06 17:15:24 UTC

Hello.

I'd like to release version 1.2 of "Commons RNG".

Apache Commons RNG v1.2 (RC2) is available for review:
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2 (svn
revision 31410)

Git tag is named "RNG_1_2_RC2":

https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC2

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1399/org/apache/commons/

Maven artifacts' SHA-512 hashes in Nexus:

commons-rng-1.2-bin-tar.gz=681530e0f26f1ac84b626de4adfc7a5c615b2784157da412b329c5ff33361a7b

commons-rng-1.2-bin-tar.gz.asc=5785291f481029c00600cca402ca37fbf9bea64a1b58db4f58c3c41270200e58

commons-rng-1.2-src-tar.gz=89d1d4fb95651c0d008d941b928e468822769a142f69c1e7f174994e3c13285c

commons-rng-1.2-bin-zip=09608ac82e654287d69cca991d516cd95f09189f412bf2be1292f10f9b7d103e

commons-rng-1.2-src-zip=aabe2a548c991ef89a7f86a5ed6b7ba9847678a0fd87b48d7d40775ba545063d

commons-rng-1.2-src-zip.asc=d676fa86a0fa81db7c9c63fb1c86dc5ae23755081186adf6f3650bee3e341e96

commons-rng-1.2-pom.asc=24d621f1b1724134d4d493e0672e9c9a0627c0e8b5614c3ef4d8030ecc14f541

commons-rng-1.2-bin-zip.asc=243e1b663c639116840301d3610abec9b5d6b68f494eee10b164fc7057b4a7e5

commons-rng-1.2-src-tar.gz.asc=7480a80014b3ec58cf3a98c84bb693ba5ea86b02361889c43893752cd9203f33

Details of changes since 1.1 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2/site/changes-report.html

Site:
http://commons.apache.org/proper/commons-rng/

KEYS:
id=B39617E095CD748DFE505816703413011E22D5B8
https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Rob Tompkins

2018-12-08 14:48:22 UTC

Permalink

+1 (I predicate this on our being ok with a java 9 build only)

clirr - good (2 info issues)
rat - good
pmd - few nits
checkstyle - good
signatures - good
build java9 only:

$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T14:33:14-04:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 9.0.4, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.1", arch: "x86_64", family: "mac"

It was a tad cumbersome working with all of the nexus artifacts for release validation.

-Rob

Post by Gilles
Hello.
I'd like to release version 1.2 of "Commons RNG".
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2 (svn revision 31410)
https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC2
https://repository.apache.org/content/repositories/orgapachecommons-1399/org/apache/commons/
commons-rng-1.2-bin-tar.gz=681530e0f26f1ac84b626de4adfc7a5c615b2784157da412b329c5ff33361a7b
commons-rng-1.2-bin-tar.gz.asc=5785291f481029c00600cca402ca37fbf9bea64a1b58db4f58c3c41270200e58
commons-rng-1.2-src-tar.gz=89d1d4fb95651c0d008d941b928e468822769a142f69c1e7f174994e3c13285c
commons-rng-1.2-bin-zip=09608ac82e654287d69cca991d516cd95f09189f412bf2be1292f10f9b7d103e
commons-rng-1.2-src-zip=aabe2a548c991ef89a7f86a5ed6b7ba9847678a0fd87b48d7d40775ba545063d
commons-rng-1.2-src-zip.asc=d676fa86a0fa81db7c9c63fb1c86dc5ae23755081186adf6f3650bee3e341e96
commons-rng-1.2-pom.asc=24d621f1b1724134d4d493e0672e9c9a0627c0e8b5614c3ef4d8030ecc14f541
commons-rng-1.2-bin-zip.asc=243e1b663c639116840301d3610abec9b5d6b68f494eee10b164fc7057b4a7e5
commons-rng-1.2-src-tar.gz.asc=7480a80014b3ec58cf3a98c84bb693ba5ea86b02361889c43893752cd9203f33
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC2/site/changes-report.html
http://commons.apache.org/proper/commons-rng/
id=B39617E095CD748DFE505816703413011E22D5B8
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thanks,
Gilles
---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Gilles

2018-12-08 18:27:34 UTC

Permalink

Post by Rob Tompkins
+1 (I predicate this on our being ok with a java 9 build only)

All modules that compose the official release:
client-api
core
simple
sampling
compile fine and pass all the tests with Java 8.

The "main" code compiles fine with Java 10, but the surefire
plugin crashes.

I do not have older JDKs at hand (and Jenkins builds broke
for some reason not clearly apparent from the console log).

Post by Rob Tompkins
clirr - good (2 info issues)

I suggest that we consider setting up CP to support
the newer
https://revapi.org/

Post by Rob Tompkins
rat - good
pmd - few nits

Those appeared after an upgrade of the tool.
On the TODO list:
https://issues.apache.org/jira/projects/RNG/issues/RNG-49

Post by Rob Tompkins
checkstyle - good
signatures - good
$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T14:33:14-04:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.1", arch: "x86_64", family: "mac"
It was a tad cumbersome working with all of the nexus artifacts for release validation.

I'm not sure what you mean here.
If it is about the checksum/signature check, I had suggested
that it could be automated: After the upload to Nexus, the
release plugin should download the artefacts and verify that
the signatures are OK.

Thanks for the review,
Gilles

Post by Rob Tompkins
-Rob

---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Rob Tompkins

2018-12-08 23:09:35 UTC

Permalink

Post by Gilles

Post by Rob Tompkins
+1 (I predicate this on our being ok with a java 9 build only)

client-api
core
simple
sampling
compile fine and pass all the tests with Java 8.
The "main" code compiles fine with Java 10, but the surefire
plugin crashes.
I do not have older JDKs at hand (and Jenkins builds broke
for some reason not clearly apparent from the console log).

Post by Rob Tompkins
clirr - good (2 info issues)

I suggest that we consider setting up CP to support
the newer
https://revapi.org/

Post by Rob Tompkins
rat - good
pmd - few nits

Those appeared after an upgrade of the tool.
https://issues.apache.org/jira/projects/RNG/issues/RNG-49

Post by Rob Tompkins
-Rob

---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org

Alex Herbert

2018-12-10 13:49:04 UTC

Permalink

+0.5 (just the issue with the table in the user manual)

That's a tough mark for just one typo! ;-)

I'm new to this.

I can change to a +1 but I think the site should be fixed.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org