Discussion:
GitHub Pull Requests
z***@avadasoftware.com
2018-10-11 20:15:06 UTC
Permalink
Hello,

I have submitted a Pull Request at
https://github.com/apache/commons-lang/pull/358. 10 days ago,
"coveralls" commented on the request and all checks passed. Otherwise,
I have heard nothing regarding the request.

When do requests get reviewed and/or commented on?

Thanks,
Zack Macomber

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
Pascal Schumacher
2018-10-12 20:02:54 UTC
Permalink
Hi Zack,

there is no hard and fast rule when pull request get reviewed and/or
commented on.

It happens whenever a committer feels motivated to do so (we are all
volunteers).

I understand that waiting a long time for pull request reviews is
demotivating.

Sorry,
Pascal
Post by z***@avadasoftware.com
Hello,
I have submitted a Pull Request at
https://github.com/apache/commons-lang/pull/358.  10 days ago,
"coveralls" commented on the request and all checks passed. Otherwise,
I have heard nothing regarding the request.
When do requests get reviewed and/or commented on?
Thanks,
Zack Macomber
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org
Sudeendra Nadager
2018-10-15 18:13:39 UTC
Permalink
Dear Zack,

I gave a shot at it. I have some comments and see if they make sense.

Regards,
Sudeendra Nadager

On 13/10/18, 01:33, "Pascal Schumacher" <***@gmx.net> wrote:

Hi Zack,

there is no hard and fast rule when pull request get reviewed and/or
commented on.

It happens whenever a committer feels motivated to do so (we are all
volunteers).

I understand that waiting a long time for pull request reviews is
demotivating.

Sorry,
Pascal
Post by z***@avadasoftware.com
Hello,
I have submitted a Pull Request at
https://github.com/apache/commons-lang/pull/358. 10 days ago,
"coveralls" commented on the request and all checks passed. Otherwise,
I have heard nothing regarding the request.
When do requests get reviewed and/or commented on?
Thanks,
Zack Macomber
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@commons.apache.org
For additional commands, e-mail: dev-***@commons.apache.org



Т���������������������������������������������������������������������ХF�V�7V'67&�&R�R���âFWb�V�7V'67&�&T6�����2�6�R��&pФf�"FF�F����6����G2�R�
Loading...